Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logging related to security #453

Open
KeithMHughesRoteraAI opened this issue Dec 2, 2021 · 2 comments
Open

Improved logging related to security #453

KeithMHughesRoteraAI opened this issue Dec 2, 2021 · 2 comments

Comments

@KeithMHughesRoteraAI
Copy link

KeithMHughesRoteraAI commented Dec 2, 2021

This is still true as of Olive Helps 0.27.7.

The logs give no detailed information if an aptitude requiring a permission in the package.json file is used, but permission has not been requested. There will be a generic log message about a permission violation, but nothing about the particular permission that was missing. The improved message could say, for example, that a network call was made to the domain foo.com and that permission was not requested for foo.com. Another would be that network access was attempted, but no network permissions were requested. Prefixing the error with Security error will make them easy to find.

A second class of helpful log messages would be messages detailing the use of a forbidden package not allowed by the sandbox, e.g. fs or process. The improved message would state the name of forbidden package, e.g. Security error: There was an attempted load of the package fs. This package is not allowed in the Olive Helps sandboxed environment.

@JosefBud-olive
Copy link
Contributor

Hello again, @KeithMHughesRoteraAI! Better logging is definitely on our radar as a priority, we'll keep you updated as we go forward with this.

@MaggieMaSS
Copy link
Contributor

Update: ticket numberHELPS-4129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants