fix: unreliable webhook behaviour on gatekeeper pod startup and shutdown #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0wl3vel
force-pushed
the
fix/webhook-availability
branch
4 times, most recently
from
46de743 to
937a91e
Compare
l0wl3vel
force-pushed
the
fix/webhook-availability
branch
from
937a91e to
fcd6e13
Compare
l0wl3vel
changed the title
l0wl3vel
changed the title
l0wl3vel
force-pushed
the
fix/webhook-availability
branch
from
fe4bc04 to
262f5c4
Compare
|
@JaydipGabani Integrated your suggestion. Could you please rerun the workflows? |
l0wl3vel
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3780 +/- ##
==========================================
- Coverage 54.49% 47.74% -6.75%
==========================================
Files 134 235 +101
Lines 12329 19852 +7523
==========================================
+ Hits 6719 9479 +2760
- Misses 5116 9484 +4368
- Partials 494 889 +395
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
l0wl3vel
force-pushed
the
fix/webhook-availability
branch
from
3f4870c to
8b50591
Compare
|
@JaydipGabani Could you please rerun the pipelines and merge this? I missed the window where I could have merged without rebase. |
|
@l0wl3vel we want approval from one more maintainer to merge. cc: @ritazh @maxsmythe @sozercan PTAL. |
Signed-off-by: Benjamin Ritter <[email protected]>
Signed-off-by: Benjamin Ritter <[email protected]>
Co-authored-by: Jaydip Gabani <[email protected]> Signed-off-by: Benjamin Ritter <[email protected]>
l0wl3vel
force-pushed
the
fix/webhook-availability
branch
from
8b50591 to
5e8f3c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes webhook requests getting routed to starting and stopping gatekeeper pods, that are not ready to serve requests. The implications of this behaviour are explained in #3776
Which issue(s) this PR fixes:
Fixes #3776
Special notes for your reviewer:
The grace period for handling termination will not work when using Tilt to test. It will terminate instantly, like it did before.
We tracked this down to the rerun-process-handler Tilt uses to wrap the application to test.
The start.sh script traps SIGTERM and INTERRUPTS, the two signals we handle, and replaces them with SIGKILL, which we do not intercept.
Running
make runyields the intended behaviour.Co-authored by Nils Federle (@nilsfed) and Paweł Kukliński (@pawelkuk)