Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly testing generic and non-generic code variants #1904

Open
praveksharma opened this issue Aug 23, 2024 · 0 comments
Open

Explicitly testing generic and non-generic code variants #1904

praveksharma opened this issue Aug 23, 2024 · 0 comments

Comments

@praveksharma
Copy link
Member

As pointed out in #1745 (comment) CI does not explicitly use the OQS_USE_CPUFEATURE_INSTRUCTION build flag to test generic and non-generic code variants right now.

The generic tests in weekly.yml do test generic code by specifying the CPU architecture to the compiler and GitHub hosted runners seem to have the required CPU extensions to run and test AVX2 code (for instance, see https://github.com/open-quantum-safe/liboqs/actions/runs/10358446454/job/28672828780 under Configure) in the linux tests in unix.yml --- so both generic and non-generic code do get tested.

Making these tests explicit by using the OQS_USE_CPUFEATURE_INSTRUCTION flag is desirable because the documentation for GitHub hosted runners does not guarantee that these runners support specific CPU flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant