-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimpleNetworkDetector uses deprecated APIs #49
Comments
Then again, because the |
There was an important API addition in the way Android provides a "default" network connectivity info on API 24 that makes this a lot easier, which is the one we use in the Elastic agent. I think it's worth waiting on the outcome of open-telemetry/opentelemetry-java#5936 before adding any further changes to |
As a side note, it seems like the overall network detection process is started here, although I can't find where this function is called, so I'm wondering if this is currently dead code @breedx-splk? |
It's been a public method on a public class, so users can use it how they please. In the original Splunk code, it was called by the |
Ah, got it! I missed it in your PR. Cheers. |
There is a build warning about the
SimpleNetworkDetector
using deprecated APIs. I believe that this is specifically related to the use ofNetworkInfo
and some of the methods (see the comments inSimpleNetworkDetector
).The Elastic android instrumentation seems to agree with a long-lived stackoverflow post about how to mitigate this.
Although things are probably still working, it would be nice to migrate to a more sophisticated/robust solution going forward.
The text was updated successfully, but these errors were encountered: