From 6609f6e49d9b0f3c953b181147136b117928cb59 Mon Sep 17 00:00:00 2001 From: hughesjj Date: Tue, 12 Nov 2024 14:56:30 -0800 Subject: [PATCH] fix checks target --- CONTRIBUTING.md | 15 ++------------- Makefile | 6 ++++-- 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index daf66c9c1eda..71417fd2772f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -203,19 +203,8 @@ When submitting a component to the community, consider breaking it down into sep * This PR is usually trivial to review, so the size limit does not apply to it. * The component should use [`In Development` Stability](https://github.com/open-telemetry/opentelemetry-collector#development) in its README. - * Before submitting a PR, run the following commands from the root of the repository to ensure your new component is meeting the repo linting expectations: - * `make checkdoc` - * `make checkmetadata` - * `make checkapi` - * `make goporto` - * `make crosslink` - * `make gotidy` - * `make genotelcontribcol` - * `make genoteltestbedcol` - * `make generate` - * `make multimod-verify` - * `make generate-gh-issue-templates` - * `make addlicense` + * As always, ensure you generate a changelog template (refer to [Adding a Changelog Entry](#adding-a-changelog-entry)). + * Before submitting a PR, run `make checks` from the root of the repository to ensure your new component is meeting the repo linting expectations. * **Second PR** should include the concrete implementation of the component. If the size of this PR is larger than the recommended size consider splitting it in multiple PRs. diff --git a/Makefile b/Makefile index 86ecba3a3276..b138b0936420 100644 --- a/Makefile +++ b/Makefile @@ -561,14 +561,16 @@ generate-gh-issue-templates: .PHONY: checks checks: + $(MAKE) gomoddownload + $(MAKE) install-tools + $(MAKE) genotelcontribcol + $(MAKE) genoteltestbedcol $(MAKE) checkdoc $(MAKE) checkmetadata $(MAKE) checkapi $(MAKE) -j4 goporto $(MAKE) crosslink $(MAKE) -j4 gotidy - $(MAKE) genotelcontribcol - $(MAKE) genoteltestbedcol $(MAKE) gendistributions $(MAKE) -j4 generate $(MAKE) multimod-verify