Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could kafka export hash parittion #12318

Closed
tuyula opened this issue Jul 12, 2022 · 12 comments
Closed

could kafka export hash parittion #12318

tuyula opened this issue Jul 12, 2022 · 12 comments
Labels
closed as inactive enhancement New feature or request exporter/kafka priority:needed Triagers reviewed the issue but need code owner to set priority Stale

Comments

@tuyula
Copy link

tuyula commented Jul 12, 2022

Is your feature request related to a problem? Please describe.
feature: we need kafka has hash parition use TraceId Key so that we can support mutiple consumer use tail_sampling

Describe the solution you'd like
cause consumer use tail_sampling, so the same traceId must consumer in the same collector

Describe alternatives you've considered
add some config for kafka product, add hash_product

@CoderPoet
Copy link

Yes, I also do tail sampling in kafka consumers, so I modified kafka exporter

@evan-bradley evan-bradley added enhancement New feature or request exporter/kafka priority:needed Triagers reviewed the issue but need code owner to set priority labels Sep 14, 2022
@github-actions
Copy link
Contributor

Pinging code owners: @pavolloffay @MovieStoreGuy. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 14, 2022
@arik-dig
Copy link

I think that issue is more than relevant.
other than tail_sampling it will allow achieve a greater cause - consumption scalability
can you please address it?

@arik-dig
Copy link

Yes, I also do tail sampling in kafka consumers, so I modified kafka exporter

@CoderPoet maybe you could propose a PR so all the community could benefit from it?
👍

@MovieStoreGuy
Copy link
Contributor

I would love to have this feature in, but I am limited in my time to contribute and spend validating the fix.

If @CoderPoet already has something that exists, that be awesome to see as an addition to the component.

I know there is conversations of using something like OTTL to define the keyed topic which would provide some benefits.

@github-actions github-actions bot removed the Stale label May 26, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 26, 2023
@arik-dig
Copy link

arik-dig commented Aug 7, 2023

opened slack message at cloud-native :
https://cloud-native.slack.com/archives/C01N6P7KR6W/p1690810287409799

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jwafle
Copy link
Contributor

jwafle commented Dec 5, 2023

Open PR to resolve this issue: #29660

@github-actions github-actions bot removed the Stale label Dec 6, 2023
MovieStoreGuy pushed a commit that referenced this issue Dec 12, 2023
**Description:** Adds the `partition_traces_by_id` option to
configuration which defaults to false. When set to true, it sets the
[message key](https://www.geeksforgeeks.org/apache-kafka-message-keys/)
on trace messages to a hexadecimal string representing the trace ID.

**Link to tracking Issue:** #12318 

**Testing:** Refined current unit tests to cover new capabilities.
Config test now covers the `partition_traces_by_id` option.
`marshaler_test.go` now tests both partitioned and non-partitioned
cases.

**Documentation:** Updated the README to include the new
`partition_traced_by_id` option in the section describing optional
configuration items.
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive enhancement New feature or request exporter/kafka priority:needed Triagers reviewed the issue but need code owner to set priority Stale
Projects
None yet
Development

No branches or pull requests

6 participants