[cmd/opampsupervisor] Make timeout for bootstrap info retrieval configurable #34996
Labels
Comments
bacherfl
added
enhancement
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This was referenced Sep 10, 2024
djaglowski
pushed a commit
that referenced
this issue
Sep 27, 2024
…he initial bootstrap information retrieval from the agent (#35000) **Description:** This PR adds a configuration option for setting the timeout for the initial bootstrap information retrieval from the agent. **Link to tracking Issue:** #34996 **Testing:** Added unit tests **Documentation:** Added description for the new option in the specification readme --------- Signed-off-by: Florian Bacher <[email protected]>
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this issue
Oct 4, 2024
…he initial bootstrap information retrieval from the agent (open-telemetry#35000) **Description:** This PR adds a configuration option for setting the timeout for the initial bootstrap information retrieval from the agent. **Link to tracking Issue:** open-telemetry#34996 **Testing:** Added unit tests **Documentation:** Added description for the new option in the specification readme --------- Signed-off-by: Florian Bacher <[email protected]>
This was referenced Oct 8, 2024
|
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This was referenced Nov 5, 2024
|
Closing this as the related PR has been merged: #35000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
cmd/opampsupervisor
Is your feature request related to a problem? Please describe.
Currently the timeout for starting the agent and waiting for an agent description to be sent is hard coded to 3 seconds:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/opampsupervisor/supervisor/supervisor.go#L364-L374
When trying out the supervisor I happened to run into this timeout occasionally, so having this configurable should help to reduce flakiness there.
Describe the solution you'd like
Add a parameter for the timeout to the Config
Describe alternatives you've considered
No response
Additional context
I'd be happy to work on a PR for that option in the config
The text was updated successfully, but these errors were encountered: