-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New component: Signal to metrics connector #35930
Comments
I think this is a great idea. Am I correct in understanding that it depends on #35621? |
Partially. In our current implementation, we have circumvented this by an internal get editor function which we use to create OTTL statement from data expressions - so not exactly a blocker. |
I'm willing to sponsor this. |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds boilerplate code for a new signal to metrics connector. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Part of #35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests provided as required. <!--Describe the documentation added.--> #### Documentation Added basic README. Will add more details with future commits. <!--Please delete paragraphs that you did not use before submitting.--> CC: @ChrsMark --------- Co-authored-by: Christos Markou <[email protected]>
…elemetry#36454) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds boilerplate code for a new signal to metrics connector. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Part of open-telemetry#35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests provided as required. <!--Describe the documentation added.--> #### Documentation Added basic README. Will add more details with future commits. <!--Please delete paragraphs that you did not use before submitting.--> CC: @ChrsMark --------- Co-authored-by: Christos Markou <[email protected]>
…elemetry#36454) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds boilerplate code for a new signal to metrics connector. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Part of open-telemetry#35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests provided as required. <!--Describe the documentation added.--> #### Documentation Added basic README. Will add more details with future commits. <!--Please delete paragraphs that you did not use before submitting.--> CC: @ChrsMark --------- Co-authored-by: Christos Markou <[email protected]>
hi, can it use log convert to gauge? if not, is there any way to do that ? |
👋 @jluncc , The component will be able to produce counters or histograms using log records, some examples are available here. Can you elaborate on your exact usage scenario? |
@lahsivjar thanks your reply i have another issue here show more detail: #36710 |
#36671) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds config validation logic and custom OTTL functions required for signal to metrics connector. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Related to: #35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Uni tests added. <!--Describe the documentation added.--> #### Documentation N/A <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <[email protected]>
…elemetry#36454) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds boilerplate code for a new signal to metrics connector. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Part of open-telemetry#35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests provided as required. <!--Describe the documentation added.--> #### Documentation Added basic README. Will add more details with future commits. <!--Please delete paragraphs that you did not use before submitting.--> CC: @ChrsMark --------- Co-authored-by: Christos Markou <[email protected]>
open-telemetry#36671) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds config validation logic and custom OTTL functions required for signal to metrics connector. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Related to: open-telemetry#35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Uni tests added. <!--Describe the documentation added.--> #### Documentation N/A <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <[email protected]>
open-telemetry#36671) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds config validation logic and custom OTTL functions required for signal to metrics connector. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Related to: open-telemetry#35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Uni tests added. <!--Describe the documentation added.--> #### Documentation N/A <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <[email protected]>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adding core logic for the signal to metrics connector. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Related to #35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests added <!--Describe the documentation added.--> #### Documentation Documentation is already added in README. <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <[email protected]>
…elemetry#36454) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds boilerplate code for a new signal to metrics connector. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Part of open-telemetry#35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests provided as required. <!--Describe the documentation added.--> #### Documentation Added basic README. Will add more details with future commits. <!--Please delete paragraphs that you did not use before submitting.--> CC: @ChrsMark --------- Co-authored-by: Christos Markou <[email protected]>
open-telemetry#36671) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds config validation logic and custom OTTL functions required for signal to metrics connector. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Related to: open-telemetry#35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Uni tests added. <!--Describe the documentation added.--> #### Documentation N/A <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <[email protected]>
…telemetry#36852) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adding core logic for the signal to metrics connector. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Related to open-telemetry#35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests added <!--Describe the documentation added.--> #### Documentation Documentation is already added in README. <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <[email protected]>
#37117) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Update signal to metrics connector to add resource attribute from telemetry settings. More information can be perused here: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/connector/signaltometricsconnector/README.md#single-writer <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Related to #35930 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests added <!--Describe the documentation added.--> #### Documentation Documentation is already added in README as part of the initial PR: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/connector/signaltometricsconnector/README.md#single-writer <!--Please delete paragraphs that you did not use before submitting.-->
The purpose and use-cases of the new component
Signal to metrics connector can produce metrics from all signal types (
logs
,metrics
, andtraces
).The currently available connectors like countconnector, spanmetricsconnector, sumconnector can perform specific tasks and become a bit hard to use with evolving use-cases. Signal to metrics connector will utilize OTTL expressions to make data manipulation from the incoming signals configurable, thus allowing the component to serve a wider range of use-cases.
The OTTL expressions can be configured depending on the metric types. For example: for histograms and exponential histograms,
count
andvalue
could be retrieved based on separate OTTL expressions whereas, for sum metric the value could be retrieved from a singlevalue
OTTL expression.Example configuration for the component
Generic configuration
Count connector use-cases
Sum connector use-cases
Span metrics connector use-cases
Convert a gauge metric to a histogram
Telemetry data types supported
traces
,metrics
, andlogs
Is this a vendor-specific component?
NO
Code Owner(s)
@lahsivjar
Sponsor (optional)
@ChrsMark
Additional context
We, at Elastic, have a working version of this component with a lot of the features for spans, datapoints, and, logrecords already developed and we would like to contribute the component upstream as we believe it could be useful to the community.
The text was updated successfully, but these errors were encountered: