[extension/db_storage] Replace mattn/go-sqlite3 with glebarez/go-sqlite #36389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiha-min-thant
requested review from
dmitryax,
atoulme and
a team
as code owners
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Signed-off-by: Thiha Min Thant <[email protected]>
thiha-min-thant
force-pushed
the
main
branch
from
222ce01 to
d9d2268
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the
mattn/go-sqlite3dependency withglebarez/go-sqlitefor SQLite database storage.The motivation for this change stems from the need for a pure Go SQLite implementation to simplify cross-platform compatibility by eliminating the dependency on CGO. Both
modernc.org/sqliteandglebarez/go-sqliteoffer pure Go SQLite drivers, but the reason glebarez/go-sqlite exists is explained in glebarez/go-sqlite#96.Link to tracking issue
Fixes #35280
Testing
Documentation