[exporter/datadog] Host metrics export is never fully disabled #36522
Labels
Comments
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
/label -needs-triage bug |
github-actions
bot
added
bug
mx-psi
pushed a commit
that referenced
this issue
Dec 10, 2024
…_metadata.enabled` (#36669) #### Description This PR avoids creating an `inframetadata.Reporter` and starting the metadata-sending goroutine when `host_metadata.enabled` is `false`, and removes some code that was used to work around the previous behavior. See tracking issue for context. When `enabled` is `false`, we leave the `exporter.metadataReporter` field as `nil`. The parts of the code accessing this field were already gated behind `enabled: true`, or `only_metadata: true` (which, in a valid config, implies `enabled: false`), so it should not cause issues. However, tests that modify the config after the exporter is created, or which manually create invalid `Config` structs may encounter segfaults. I assumed we do not mind segfaults in cases of incorrect internal use, and fixed the one test that was failing because of this. #### Link to tracking issue Fixes #36522
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this issue
Dec 17, 2024
…_metadata.enabled` (open-telemetry#36669) #### Description This PR avoids creating an `inframetadata.Reporter` and starting the metadata-sending goroutine when `host_metadata.enabled` is `false`, and removes some code that was used to work around the previous behavior. See tracking issue for context. When `enabled` is `false`, we leave the `exporter.metadataReporter` field as `nil`. The parts of the code accessing this field were already gated behind `enabled: true`, or `only_metadata: true` (which, in a valid config, implies `enabled: false`), so it should not cause issues. However, tests that modify the config after the exporter is created, or which manually create invalid `Config` structs may encounter segfaults. I assumed we do not mind segfaults in cases of incorrect internal use, and fixed the one test that was failing because of this. #### Link to tracking issue Fixes open-telemetry#36522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
exporter/datadog
Describe the issue you're reporting
Description
When setting
exporters.datadog.host_metadata.enabled: false, theinframetadata.Reporter.ConsumeResourceandConsumeHostMetadatamethods are no longer called, which means no host data is collected. However, aninframetadata.Reporteris still created, and theReporter.Runfunction, which periodically exports the collected data, is still called.Presumably, this has no user impact, but it caused a PR to require some unintuitive workarounds.
I believe a solution would be to skip the call to
factory.Reporterincreate(Metrics|Logs|Traces)Exporterwhenenabledisfalse, and leave(metrics|logs|traces)Exporter.metadataReporteras nil. Some additional nil checks may be necessary. Moreover, removing aforementioned workaround would be good.The text was updated successfully, but these errors were encountered: