Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated methods cause issues in dependencies #10447

Closed
codeboten opened this issue Jun 20, 2024 · 3 comments · Fixed by open-telemetry/opentelemetry-collector-contrib#33726
Assignees

Comments

@codeboten
Copy link
Contributor

The following PR #10423 causes issues w/ dependencies that rely on the funcs/structs removed:

# github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter
Error: /home/runner/go/pkg/mod/github.com/!data!dog/datadog-agent/comp/otelcol/otlp/components/exporter/[email protected]/factory.go:61:10: undefined: exp.CreateSettings
WARN invalid TestEvent: FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector [build failed]
bad output from test2json: FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector [build failed]
✓  internal/metadata (1.012s)

=== Errors
ERROR rerun aborted because previous run had errors
Error: /home/runner/go/pkg/mod/github.com/!data!dog/datadog-agent/comp/otelcol/otlp/components/exporter/[email protected]/factory.go:61:10: undefined: exp.CreateSettings
make[3]: *** [../../Makefile.Common:126: test] Error 3
@codeboten
Copy link
Contributor Author

@songy23 @mx-psi can you take a look at this dependency?

@mx-psi mx-psi self-assigned this Jun 20, 2024
mx-psi added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue Jun 24, 2024
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Bumps Datadog Agent dependencies up to
DataDog/datadog-agent@10454a3

**Link to tracking Issue:** Fixes
open-telemetry/opentelemetry-collector/issues/10447
@yurishkuro
Copy link
Member

@mx-psi how can we ensure that the deprecation practices are followed more strictly? I think in the last release cycle some structs were first deprecated but then removed in the same cycle, so the impact on the users was that the structs just disappeared, and required investigation into what replaced them, which wouldn't be necessary if the removal happened in the following release (deprecation messages would've pointed to the replacement).

@mx-psi
Copy link
Member

mx-psi commented Jun 25, 2024

@yurishkuro I think it would really help to address #7443, but nobody is working on it. There are also some instances in which it's kind of hard for us to do things in two steps (e.g. when changing a method's type on an interface). Do you have thoughts on how we should handle those?

Also, if you have details about the concrete breaking change we can see if we can learn something specific about that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants