Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[componentstatus] Consider removing timestamp from Event #10763

Open
TylerHelmuth opened this issue Jul 31, 2024 · 1 comment
Open

[componentstatus] Consider removing timestamp from Event #10763

TylerHelmuth opened this issue Jul 31, 2024 · 1 comment

Comments

@TylerHelmuth
Copy link
Member

          Timestamp seem to be use-less, because it is always "now", which means consumers (watchers) can also read if they need it.

Originally posted by @bogdandrutu in #10730 (comment)

@mwear
Copy link
Member

mwear commented Jul 31, 2024

I believe that we should keep the timestamp as the observed time is not the same time as the observation. Since status watchers are dispatched in sequence, any status watcher that does a non-trivial amount of work, or something that could block (like writing to an event to a channel) could delay the observed time for subsequent watchers. This would be especially problematic if the delay was variable between invocations. Currently the timestamp is used by the health check extension for time calculations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants