Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Summary metrics #3058

Closed
santigimeno opened this issue Sep 12, 2024 · 2 comments
Closed

Support Summary metrics #3058

santigimeno opened this issue Sep 12, 2024 · 2 comments

Comments

@santigimeno
Copy link

Hello everyone.

In our project we integrate opentelemetry-cpp to export our telemetry data using the OTLP exporters the library provides. Some of the metrics we export fit better as Summary but the library doesn't support it. I understand the reason being Summaries are declared Legacy in the spec.

I've added the support myself in the opentelemetry-cpp version we use in our project but would like to upstream the changes. So I was wondering whether you'd be open for a PR that allows users to export Summary metrics (it doesn't cover things like instrument creation, etc).

Thanks

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 12, 2024
@lalitb
Copy link
Member

lalitb commented Sep 12, 2024

Summary is not part of the specs, probably because most of it's use-cases can be covered through Histograms. And it's there in OTLP proto for integration with non-otel components. I'm not sure if implementing support for non-spec features is advisable.

@santigimeno
Copy link
Author

Fair enough. I read the OTLP spec and thought it was a valid use case for apps that already exist out there which want to integrate with other OpenTelemetry components and that generate and need the percentiles that Summaries define for which either is not possible to migrate to Histograms, or Histograms don't cover exactly their use case.

Anyway, as soon as our changes are published I'll post a link to it in the issue in case someone needs smthg similar.

Thanks

@marcalff marcalff removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants