Naming of Filter Func<T, bool> properties convention is confusing #3878
buvinghausen
started this conversation in
General
Replies: 1 comment 1 reply
-
@buvinghausen, could you please check #3816 and provide some feedback? |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Honestly the name feels like the property belongs in the movie Tenet's inverted world.
Rationale:
If the filter returns true it should NOT record the event because it has been filtered out. That is exactly the opposite of what actually happens.
Rather than invert everyone's code I think you should name the properties something like StartActivity or something where it's implied that true = Record Activity and false = Skip Activity
Language is important and I shouldn't have to read the documentation or code to understand the desired outcomes.
Beta Was this translation helpful? Give feedback.
All reactions