-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otelmongo] bump semconv to 1.26.0 #6171
Comments
A major version release of otelmongo should be planned before bumping to 1.26.0: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/versioning-and-stability.md#semantic-conventions-stability
|
@prestonvasquez, why was it closed? |
@pellared I wasn't aware we still wanted to do this. Should I re-open the PR? |
I do not follow why we want to create a major version of I think it may make sense to coordinate the strategy of bumping the DB semconvs to the latest version at least with @XSAM who maintains https://github.com/XSAM/otelsql. |
@pellared The rationale can be found here: open-telemetry/semantic-conventions#1502 (comment)
Once we bump to 1.x, |
@prestonvasquez, there are two things: stability of semantic conventions and stability of instrumentation library.
We can still have unstable instrumentation library ( The You can look at HTTP Instrumentation project how we want to help Additional reference: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/telemetry-stability.md |
What do you propose we do? |
This is exactly where we are, right?
I propose to implement |
Problem Statement
otelmongo is currently using semconv/v1.17.0, suggest updating to semconv/v1.26.0.
Proposed Solution
key/value pair changes migrating from 1.17.0 to 1.26.0 include:
DBOperation
DBOperationName
db.operation
db.operation.name
DBName
DBNamespace
db.name
db.namespace
NetPeerName
NetworkPeerAddress
net.peer.name
network.peer.address
NetPeerPort
NetworkPeerPort
net.peer.port
network.peer.port
NetTransportTCP
NetworkingTransportTCP
net.transport
network.transport
ip_
portion defined on the deprecatednet.trasnport
. Instead, this value is eithertcp
orudp
.DBStatement
DBQueryText
db.statement
db.query.text
Db.query.text
seemed like a natural fit.Alternatives
Since these fields are deprecated, there is no alternative other than leaving the semconv version static.
Prior Art
NA
Additional Context
It's worth noting that this is a breaking change if telemetry key/values are considered stable.
The text was updated successfully, but these errors were encountered: