Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow spec advice on span limits, batch processors #7024

Open
jack-berg opened this issue Jan 15, 2025 · 5 comments
Open

Follow spec advice on span limits, batch processors #7024

jack-berg opened this issue Jan 15, 2025 · 5 comments
Labels

Comments

@jack-berg
Copy link
Member

Working on #7023 to implement spec PR open-telemetry/opentelemetry-specification#4331, I realized other parts of our implementation are not aligned with the spec:

  • SpanLimitsBuilder / LogLimitsBuilder enforce that all the values are positive, when the spec (rightly) says that 0 is an acceptable value. LogLimitsBuilder has the same issues.
  • BatchSpanProcessorBuilder / BatchLogRecordProcessorBuilder don't enforce any limits around max queue size. This means its possible to set the queue size to zero or a negative value, which is not allowed in the spec. Not sure what the underlying queue implementations do with a zero or negative value, but we add checks for this. Also, the max export size must be less than or equal to the max queue size.
@jack-berg jack-berg added Feature Request Suggest an idea for this project good first issue help wanted labels Jan 15, 2025
@manojks1999
Copy link

@jack-berg can I work on this

@jack-berg
Copy link
Member Author

Go for it!

@devatbosch
Copy link

Hi @jack-berg ,

Hope you are doing good.

Just wanted to know, if you are expecting to get any help/general improvement across any part of the repository, I can help you with that.

Please do let me know, in-case of any such issue even its a bit difficult, meanwhile I try to find a few...

@jack-berg
Copy link
Member Author

Hi thanks @devatbosch - take a look at the help wanted section in the readme and see if you're up for anything discussed there!

@onurkybsi
Copy link

Hey @jack-berg, I created a PR regarding this issue, would you have a chance to take a look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants