From 484a112d56b0da14cc983c1f67d7c3710ce5131e Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Wed, 20 Mar 2024 14:05:39 +0100 Subject: [PATCH 1/2] chore(changelog): move entry that accidentally ended up in a previous version --- experimental/CHANGELOG.md | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 8a19a85904b..e9bd486d4fe 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -6,6 +6,21 @@ All notable changes to experimental packages in this project will be documented ### :boom: Breaking Change +* fix(exporter-*-otlp-grpc)!: lazy load gRPC to improve compatibility with `@opentelemetry/instrumenation-grpc` [#4432](https://github.com/open-telemetry/opentelemetry-js/pull/4432) @pichlermarc + * Fixes a bug where requiring up the gRPC exporter before enabling the instrumentation from `@opentelemetry/instrumentation-grpc` would lead to missing telemetry + * Breaking changes, removes several functions and properties that were used internally and were not intended for end-users + * `getServiceClientType()` + * this returned a static enum value that would denote the export type (`SPAN`, `METRICS`, `LOGS`) + * `getServiceProtoPath()` + * this returned a static enum value that would correspond to the gRPC service path + * `metadata` + * was used internally to access metadata, but as a side effect allowed end-users to modify metadata on runtime. + * `serviceClient` + * was used internally to keep track of the service client used by the exporter, as a side effect it allowed end-users to modify the gRPC service client that was used + * `compression` + * was used internally to keep track of the compression to use but was unintentionally exposed to the users. It allowed to read and write the value, writing, however, would have no effect. + + ### :rocket: (Enhancement) ### :bug: (Bug Fix) @@ -62,19 +77,6 @@ All notable changes to experimental packages in this project will be documented * This breaking change only affects users that are using the *experimental* `@opentelemetry/instrumentation/hook.mjs` loader hook AND Node.js 18.19 or later: * This reverts back to an older version of `import-in-the-middle` due to * This version does not support Node.js 18.19 or later -* fix(exporter-*-otlp-grpc)!: lazy load gRPC to improve compatibility with `@opentelemetry/instrumenation-grpc` [#4432](https://github.com/open-telemetry/opentelemetry-js/pull/4432) @pichlermarc - * Fixes a bug where requiring up the gRPC exporter before enabling the instrumentation from `@opentelemetry/instrumentation-grpc` would lead to missing telemetry - * Breaking changes, removes several functions and properties that were used internally and were not intended for end-users - * `getServiceClientType()` - * this returned a static enum value that would denote the export type (`SPAN`, `METRICS`, `LOGS`) - * `getServiceProtoPath()` - * this returned a static enum value that would correspond to the gRPC service path - * `metadata` - * was used internally to access metadata, but as a side effect allowed end-users to modify metadata on runtime. - * `serviceClient` - * was used internally to keep track of the service client used by the exporter, as a side effect it allowed end-users to modify the gRPC service client that was used - * `compression` - * was used internally to keep track of the compression to use but was unintentionally exposed to the users. It allowed to read and write the value, writing, however, would have no effect. ### :bug: (Bug Fix) From 63d7d123e25fee6424f3ad017b440650400971a1 Mon Sep 17 00:00:00 2001 From: Marc Pichler Date: Wed, 20 Mar 2024 15:01:07 +0100 Subject: [PATCH 2/2] fixup! chore(changelog): move entry that accidentally ended up in a previous version --- experimental/CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index e9bd486d4fe..648beacf2ae 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -20,7 +20,6 @@ All notable changes to experimental packages in this project will be documented * `compression` * was used internally to keep track of the compression to use but was unintentionally exposed to the users. It allowed to read and write the value, writing, however, would have no effect. - ### :rocket: (Enhancement) ### :bug: (Bug Fix)