From 2ddb076454c46a2656e594508b370cd6766bcece Mon Sep 17 00:00:00 2001 From: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com> Date: Tue, 26 Nov 2024 08:58:39 -0800 Subject: [PATCH] Remove unused assertEqualSpanInstrumentationInfo (#4310) * Remove assertEqualSpanInstrumentationInfo * Changelog * Update CHANGELOG.md Co-authored-by: Riccardo Magliocchetti --------- Co-authored-by: Riccardo Magliocchetti Co-authored-by: Leighton Chen --- CHANGELOG.md | 2 ++ .../src/opentelemetry/test/test_base.py | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b83101842f..9b62a4ef39 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ([#4311](https://github.com/open-telemetry/opentelemetry-python/pull/4311)) - sdk: fix serialization of logs severity_number field to int ([#4324](https://github.com/open-telemetry/opentelemetry-python/pull/4324)) +- Remove `TestBase.assertEqualSpanInstrumentationInfo` method, use `assertEqualSpanInstrumentationScope` instead + ([#4310](https://github.com/open-telemetry/opentelemetry-python/pull/4310)) ## Version 1.28.0/0.49b0 (2024-11-05) diff --git a/tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py b/tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py index 456bd1413f..b33b152392 100644 --- a/tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py +++ b/tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py @@ -70,10 +70,6 @@ def get_finished_spans(self): self, self.memory_exporter.get_finished_spans() ) - def assertEqualSpanInstrumentationInfo(self, span, module): - self.assertEqual(span.instrumentation_info.name, module.__name__) - self.assertEqual(span.instrumentation_info.version, module.__version__) - def assertEqualSpanInstrumentationScope(self, span, module): self.assertEqual(span.instrumentation_scope.name, module.__name__) self.assertEqual(