Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate Resource Detectors to auto instrumentation #3172

Closed
ocelotl opened this issue Feb 14, 2023 · 2 comments
Closed

Incorporate Resource Detectors to auto instrumentation #3172

ocelotl opened this issue Feb 14, 2023 · 2 comments
Assignees
@ocelotl
Labels
feature-request

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Feb 14, 2023

Right now it is not possible to set Resource Detectors when running with auto instrumentation, add a feature to do that.
@ocelotl ocelotl self-assigned this Feb 14, 2023
@srikanthccv
Copy link
Member

FYI open-telemetry/opentelemetry-specification#2948

ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 16, 2023
@ocelotl
Incorportate resource detectors to auto instrumentation
d560605 
This is an experimental feature.

Fixes open-telemetry#3172
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 16, 2023
@ocelotl
Incorporate resource detectors to auto instrumentation
3283a85 
This is an experimental feature.

Fixes open-telemetry#3172
@ocelotl ocelotl mentioned this issue Feb 16, 2023
Merged
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 16, 2023
@ocelotl
Incorporate resource detectors to auto instrumentation
70e8efe 
This is an experimental feature.

Fixes open-telemetry#3172
@lzchen lzchen mentioned this issue Feb 21, 2023
Closed
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 24, 2023
@ocelotl
Incorporate resource detectors to auto instrumentation
d44d462 
This is an experimental feature.

Fixes open-telemetry#3172
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 24, 2023
@ocelotl
Incorporate resource detectors to auto instrumentation
24a92c1 
This is an experimental feature.

Fixes open-telemetry#3172
@ocelotl
Copy link
Contributor Author

ocelotl commented Feb 28, 2023

Closing as suggested.

@ocelotl ocelotl closed this as completed Feb 28, 2023
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 13, 2023
@ocelotl
Incorporate resource detectors to auto instrumentation
27904a1 
This is an experimental feature.

Fixes open-telemetry#3172
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 17, 2023
@ocelotl
Incorporate resource detectors to auto instrumentation
98f4be1 
This is an experimental feature.

Fixes open-telemetry#3172
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 23, 2023
@ocelotl
Incorporate resource detectors to auto instrumentation
ea136f0 
This is an experimental feature.

Fixes open-telemetry#3172
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Mar 29, 2023
@ocelotl
Incorporate resource detectors to auto instrumentation
1c6714a 
This is an experimental feature.

Fixes open-telemetry#3172
ocelotl added a commit that referenced this issue Mar 31, 2023
@ocelotl @srikanthccv
Incorporate resource detectors to auto instrumentation (#3181)
2e0d8ee 
* Make entry_points behave the same across Python versions

Fixes #3167

* Refactor function

* Fix mypy

* Incorporate resource detectors to auto instrumentation

This is an experimental feature.

Fixes #3172

* Rename environment variable

* Revert previous commits

* Refactor to use importlib-metadata library

* Use get_aggregate_resources

* Fix mypy

* Add CHANGELOG entry

* Fix typo in environment variable

* Add OTELResourceDetector by default

* Move to unreleased section

* Fix entry point name in the documentation

* Update opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py

Co-authored-by: Srikanth Chekuri <[email protected]>

---------

Co-authored-by: Srikanth Chekuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocelotl @srikanthccv