Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting Started: manual instrumentation, traces, app doesn't run #3544

Closed
tigrannajaryan opened this issue Nov 22, 2023 · 1 comment · Fixed by open-telemetry/opentelemetry.io#3591
Closed

Getting Started: manual instrumentation, traces, app doesn't run #3544

tigrannajaryan opened this issue Nov 22, 2023 · 1 comment · Fixed by open-telemetry/opentelemetry.io#3591
Assignees
@lzchen
Labels
bug Something isn't working

Comments

@tigrannajaryan
Copy link
Member

Describe your environment
Mac OS X
Python 3.9.6

Steps to reproduce
Follow steps in https://opentelemetry.io/docs/instrumentation/python/getting-started/

  • Installation
  • Create and launch an HTTP Server
  • Instrumentation
  • Add manual instrumentation to automatic instrumentation
  • Traces

What is the expected behavior?
App to run.

What is the actual behavior?
App fails to start. Output:

  File "app.py", line 5, in <module>
    tracer = trace.get_tracer("diceroller.tracer")
NameError: name 'trace' is not defined

Additional context
Part of review open-telemetry/community#1751

app.py attached: app.py.txt
@tigrannajaryan tigrannajaryan added the bug Something isn't working label Nov 22, 2023
@lzchen lzchen self-assigned this Nov 22, 2023
@lzchen lzchen mentioned this issue Nov 22, 2023
Merged
@emdneto
Copy link
Member

emdneto commented Jun 24, 2024

@lzchen I think this can be closed, right?

@lzchen lzchen closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update getting-started.md fix trace example open-telemetry/opentelemetry.io
3 participants
@tigrannajaryan @emdneto @lzchen