Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong test value for default timeout in OTLP Exporter Mixin #4057

Open
ocelotl opened this issue Jul 15, 2024 · 0 comments
Open

Wrong test value for default timeout in OTLP Exporter Mixin #4057

ocelotl opened this issue Jul 15, 2024 · 0 comments

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jul 15, 2024

          Either I don't understand the change or there is a new bug here. How can it be correct to change `start_time` and `now` from seconds to nanoseconds without changing the `30 / 1000`?

Secondly, does anyone understand what this assert is supposed to do? I understand it somehow like: "Ensure that the shutdown took at least 30 seconds.". If this is the case, shouldn't it be 30 * 1000 then originally and now `30 * 1e9?

Originally posted by @LarsMichelsen in #4014 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant