Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracecontext tests #4105

Open
xrmx opened this issue Aug 3, 2024 · 3 comments · May be fixed by #4109
Open

Update tracecontext tests #4105

xrmx opened this issue Aug 3, 2024 · 3 comments · May be fixed by #4109
Labels
bug Something isn't working good first issue Good first issue

Comments

@xrmx
Copy link
Contributor

xrmx commented Aug 3, 2024

Describe your environment

OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
SDK version: (e.g., 1.25.0)
API version: (e.g., 1.25.0)

What happened?

Tracecontext tests have the following warning and we are using a version from 2019. It would be nice to try to update it to a more recent version to avoid warnings and get other improvements done over the years.

opentelemetry-python/target/trace-context/test/tracecontext/tracestate.py:68: SyntaxWarning: "is" with a literal. Did you mean "=="?

Steps to Reproduce

tracecontext job in CI, see scripts/tracecontext-integration-test.sh

Expected Result

No warning

Actual Result

A warning

Additional context

No response

Would you like to implement a fix?

No

@xrmx xrmx added bug Something isn't working good first issue Good first issue labels Aug 3, 2024
@FraserYu
Copy link

FraserYu commented Aug 5, 2024

hey @xrmx I'd like to take this task as my starting point of opentelemetry to see if I can upgrade a relatively latest version, could you please guide me how can i start 127.0.0.1:5000 service so I can run scripts/tracecontext-integration-test.sh? thanks in advance

Metal-Bat added a commit to Metal-Bat/opentelemetry-python that referenced this issue Aug 6, 2024
@Ali-Alnosairi
Copy link
Contributor

Hi @xrmx
Can I work on this ?

@Ali-Alnosairi
Copy link
Contributor

could you please guide me how can i start 127.0.0.1:5000 service so I can run scripts/tracecontext-integration-test.sh? thanks in advance

+1

the test failed :
Cannot connect to host 127.0.0.1:5000 ssl:default [Connect call failed ('127.0.0.1', 5000)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants