Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider temp-env for environment testing #1383

Closed
hdost opened this issue Nov 18, 2023 · 1 comment · Fixed by #1403
Closed

Consider temp-env for environment testing #1383

hdost opened this issue Nov 18, 2023 · 1 comment · Fixed by #1403

Comments

@hdost
Copy link
Contributor

hdost commented Nov 18, 2023

I moved common code for http and tonic exporters in exporter/mod.rs (function to parse header from string and test helper to run tests with isolated env variables)
I wanted to minimize the changes but maybe it should be a good idea to use a crate like https://crates.io/crates/temp-env for environment related testing

Originally posted by @harscoet in #1377
@harscoet harscoet mentioned this issue Nov 18, 2023
Merged
4 tasks
@jtescher
Copy link
Member

Yeah those tests are flakey currently. Good to get a fix 👍

@TommyCpp TommyCpp mentioned this issue Nov 26, 2023
Merged
4 tasks
hdost pushed a commit that referenced this issue Nov 27, 2023
@TommyCpp
fix(sdk, zipkin, otlp): use temp_env for testing (#1403)
f2d57b1 
Fixes #1383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sdk, zipkin, otlp): use temp_env for testing TommyCpp/opentelemetry-rust
2 participants
@jtescher @hdost