From 64f23406020003a8d486314a5f814d44368049ae Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Fri, 1 Mar 2024 08:25:23 -0800 Subject: [PATCH] Formalize the overflow and cardinality limit interaction (#3912) --- CHANGELOG.md | 2 ++ specification/metrics/sdk.md | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f40ac8223e3..d4003818053 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,8 @@ release. - Remove implementation specific specification from metric API. ([#3890](https://github.com/open-telemetry/opentelemetry-specification/pull/3890)) +- Formalize the interaction between cardinality limit and overflow attribute. + ([#3912](https://github.com/open-telemetry/opentelemetry-specification/pull/3912)) ### Logs diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index b049a733d59..7bc09deef0e 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -759,9 +759,9 @@ independently aggregated because of the limit. The SDK MUST create an Aggregator with the overflow attribute set prior to reaching the cardinality limit and use it to aggregate events -for which the correct Aggregator could not be created. The maximum -number of distinct, non-overflow attributes is one less than the -limit, as a result. +for which the correct Aggregator could not be created. The SDK MUST provide the +guarantee that overflow would not happen if the maximum number of distinct, +non-overflow attribute sets is less than or equal to the limit. #### Synchronous instrument cardinality limits