-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in Trace receiver tutorial #2094
Comments
@Chinwendu20 can you take your proposed solution and turn it into a PR, makes it easier for us to review. Thanks |
Okay @svrnm |
https://cloud-native.slack.com/archives/C02UN96HZH6/p1671184942392839 leaving the discussion on the |
I've created a separate issue to track the Windows-only (AFAIK) build problem, so that we can keep this issue focused on it's original topic: |
I will also consolidate this issue with #1802 -- the issue is ultimately that the APIs are out of date w.r.t. the latest collector framework. |
What needs to be changed?
Here the interval field was defined as a string:
While creating the createDefaultConfig function, a time.Duration type was assigned to that field, this would cause an error:
Proposed solution:
https://github.com/Chinwendu20/Tailtracer/blob/2b0e65243ca9bf4fb71665fc71b1539cde9debc8/factory.go#L14-L21
The text was updated successfully, but these errors were encountered: