Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Trace receiver tutorial #2094

Closed
Chinwendu20 opened this issue Dec 12, 2022 · 6 comments
Closed

Error in Trace receiver tutorial #2094

Chinwendu20 opened this issue Dec 12, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@Chinwendu20
Copy link

What needs to be changed?
Here the interval field was defined as a string:

image

While creating the createDefaultConfig function, a time.Duration type was assigned to that field, this would cause an error:

image

Proposed solution:
https://github.com/Chinwendu20/Tailtracer/blob/2b0e65243ca9bf4fb71665fc71b1539cde9debc8/factory.go#L14-L21

@Chinwendu20 Chinwendu20 added the bug Something isn't working label Dec 12, 2022
@svrnm
Copy link
Member

svrnm commented Dec 13, 2022

@Chinwendu20 can you take your proposed solution and turn it into a PR, makes it easier for us to review. Thanks

@Chinwendu20
Copy link
Author

Okay @svrnm

@Chinwendu20
Copy link
Author

Trying to submit a PR, after cloning the repo and running an npm install, I get this error:
image
I have posted this on the slack group, would be grateful for any help that I get

@svrnm
Copy link
Member

svrnm commented Dec 19, 2022

https://cloud-native.slack.com/archives/C02UN96HZH6/p1671184942392839 leaving the discussion on the npm install here for reference.

@chalin
Copy link
Contributor

chalin commented Dec 19, 2022

I've created a separate issue to track the Windows-only (AFAIK) build problem, so that we can keep this issue focused on it's original topic:

@cartermp
Copy link
Contributor

I will also consolidate this issue with #1802 -- the issue is ultimately that the APIs are out of date w.r.t. the latest collector framework.

@cartermp cartermp closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants