Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic convention on enduser is deprecated and should use user #4967

Closed
2 tasks done
evan361425 opened this issue Aug 6, 2024 · 5 comments · Fixed by #4994 or #5000
Closed
2 tasks done

Semantic convention on enduser is deprecated and should use user #4967

evan361425 opened this issue Aug 6, 2024 · 5 comments · Fixed by #4994 or #5000
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file docsy

Comments

@evan361425
Copy link

evan361425 commented Aug 6, 2024

What needs to be changed? Describe the update that is required.

In the register of semantic conventions, sidebar should place user not enduser which is already deprecated

What is the name + path of the page that needs changed? The relative path and page title where you found a problem.

Sidebar should place user not enduser and general attributes (/specs/semconv/general/attributes/#general-identity-attributes) should also use user attributes instead.


Tasks

@evan361425 evan361425 added the bug Something isn't working label Aug 6, 2024
@svrnm
Copy link
Member

svrnm commented Aug 6, 2024

thanks for reporting @evan361425

@chalin can you take a look here, both should be in the sidebar (since we do not remove deprecated entitites), but only enduser shows up. I assume something needs to be fixed in a script building the semantic conventions?

@svrnm svrnm moved this to Need SIG Review in SIG Comms: PRs & Issues Aug 6, 2024
@svrnm svrnm moved this from Need SIG Review to Need Docs Review in SIG Comms: PRs & Issues Aug 6, 2024
@chalin chalin self-assigned this Aug 6, 2024
@chalin
Copy link
Contributor

chalin commented Aug 6, 2024

We surfaced a bug in Hugo the last time. I suspect that might be the case again here. I'll keep you posted on the progress of my investigation.

@chalin
Copy link
Contributor

chalin commented Aug 7, 2024

Nope, it was simply due to the sidebar section-entry limit, which many of us trip on over and over again. Docsy will soon issue a warning about this, see google/docsy#2069.

@chalin chalin added dependencies Pull requests that update a dependency file docsy and removed sig:semconv labels Aug 7, 2024
@github-project-automation github-project-automation bot moved this from Need Docs Review to Done in SIG Comms: PRs & Issues Aug 7, 2024
@chalin
Copy link
Contributor

chalin commented Aug 7, 2024

Oops, reopening to track removal of the workaround.

@chalin chalin reopened this Aug 7, 2024
@github-project-automation github-project-automation bot moved this from Done to Need Docs Review in SIG Comms: PRs & Issues Aug 7, 2024
@github-project-automation github-project-automation bot moved this from Need Docs Review to Done in SIG Comms: PRs & Issues Aug 8, 2024
@evan361425
Copy link
Author

Thanks for your quick response🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file docsy
Projects
Status: Done
3 participants