Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python zero-code instrumentation does not use bytecode injection #5089

Closed
aabmass opened this issue Aug 22, 2024 · 8 comments
Closed

Python zero-code instrumentation does not use bytecode injection #5089

aabmass opened this issue Aug 22, 2024 · 8 comments
Labels

Comments

@aabmass
Copy link
Member

aabmass commented Aug 22, 2024

https://opentelemetry.io/docs/zero-code/python/

The intro paragraph says

It dynamically injects bytecode to capture telemetry from many popular libraries and frameworks.

But this is not accurate. We use monkey patching in almost all cases.

@cartermp
Copy link
Contributor

Huh, I had thought maybe this was some shared text but it seems this was only written for the Python docs. Yeah, this should change.

@CFly17
Copy link
Contributor

CFly17 commented Aug 30, 2024

Hi @aabmass! Feel free to assign to me, I'm happy to contribute and update this documentation.
Thanks for pointing this out.

@cartermp
Copy link
Contributor

@CFly17 we don't assign issues in this repo, but feel free to just send a PR and we'll gladly review it.

@CFly17
Copy link
Contributor

CFly17 commented Aug 30, 2024

Thanks @cartermp. This is my first contribution to open source.
#5130

@CFly17
Copy link
Contributor

CFly17 commented Aug 30, 2024

attempting to fix failed checks for

  • MARKDOWN linter
  • REFCACHE updates?
  • FILE FORMAT

After pushing what I believe to be the fixes, I proceeded to sync with main and the checks stopped.
I believe I need workflow approval from a maintainer now.

@svrnm
Copy link
Member

svrnm commented Sep 4, 2024

is this fixed via #5130?

@CFly17
Copy link
Contributor

CFly17 commented Sep 5, 2024

Yes @svrnm. But my merged PR left behind an unused refcache link.
If the code was already merged, should I push to the same branch, or open a new PR to remove this line?

@svrnm
Copy link
Member

svrnm commented Sep 5, 2024

Yes @svrnm. But my merged PR left behind an unused refcache link. If the code was already merged, should I push to the same branch, or open a new PR to remove this line?

I guess we have many of those, so do not worry about it ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

5 participants