Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host PHP API Docs via netlify #5254

Closed
svrnm opened this issue Sep 26, 2024 · 6 comments
Closed

Host PHP API Docs via netlify #5254

svrnm opened this issue Sep 26, 2024 · 6 comments
Labels
CI/infra CI & infrastructure enhancement New feature or request sig:php

Comments

@svrnm
Copy link
Member

svrnm commented Sep 26, 2024

This is step 2 and a follow up to open-telemetry/opentelemetry-php#1378:

PHP is one of the few languages1 that does not have API Docs published yet. I provided a PR that adds phpDocumentor to the repo which creates the API Docs. What remains is where and how to host them. My proposal is that we host them via netlify, as this comes with a few advantages:

  • PHP SIG does not need to do their own hosting (via readthedocs, github pages), or maintain workflows, since this is covered by SIG Comms and netlify can pick up changes via commits similar to how the opentelemetry.io page is built today.
  • We can provide a *.opentelemetry.io location (php.api-docs.opentelemetry.io or opentelemetry.io/api-docs/php with a rewrite proxy)

What needs to be done:

  • Go into the netlify console, setup a new page (e.g. php.api-docs.opentelemetry.io), point it to opentelemetry-php repo, let it run
  • Setup the rewrite proxy for opentelemetry.io/api-docs/php
  • That's it :-)

Note, that this can also be a pilot and if this works well, we can provide something similar to other SIGs.

cc @open-telemetry/php-approvers @open-telemetry/docs-approvers

Footnotes

  1. only other language is swift

@svrnm svrnm added enhancement New feature or request CI/infra CI & infrastructure sig:php labels Sep 26, 2024
@theletterf theletterf moved this to Need SIG Review in SIG Comms: PRs & Issues Sep 27, 2024
@chalin
Copy link
Contributor

chalin commented Sep 30, 2024

Overall, I like the idea of hosting via Netlify.

I'd like to suggest that the PHP API reference have the following canonical path:

  • /docs/languages/php/api

Just like for other languages. We can then separately decide what kind of aliasing we might want to have (or not have). WDYT?

@chalin
Copy link
Contributor

chalin commented Sep 30, 2024

Thinking about this more ... The OTel website has enough complexity already, that I'd avoid introducing the overhead of having to maintain subdomains like php.api.opentelemetry.io for each language.

@svrnm
Copy link
Member Author

svrnm commented Sep 30, 2024

The OTel website has enough complexity already,

This would be an independent netlify site, so not getting into the otel website itself except introducing redirects.

that I'd avoid introducing the overhead of having to maintain subdomains like php.api.opentelemetry.io for each language.

So you would rather have it the SIG PHP hosted themselves using github pages / read the docs, like other languages are doing it?

@chalin
Copy link
Contributor

chalin commented Sep 30, 2024

Sorry for the confusion: my comment wasn't about hosting on Netlify (which I'm ok with), it was about not introducing the <lang>.api.otel.io subdomains.

@svrnm
Copy link
Member Author

svrnm commented Oct 1, 2024

Sorry for the confusion: my comment wasn't about hosting on Netlify (which I'm ok with), it was about not introducing the <lang>.api.otel.io subdomains.

The subdomain would only be introduced for those languages that are hosted on netlify, because that looks better than https://main--opentelemetry-php.netlify.app/, except we only do the rewrite with proxy and have it under opentelemetry.io/path/to/it/php, although in that case I would prefer to have it outside the existing tree (i.e. /docs/languages/php/api), since we already see that this may lead to issues as in #5211, so opentelemetry.io/api/php might be a safer choice imho

@chalin
Copy link
Contributor

chalin commented Nov 8, 2024

This can be closed, right @svrnm?

@svrnm svrnm closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
@github-project-automation github-project-automation bot moved this from Need SIG Review to Done in SIG Comms: PRs & Issues Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure enhancement New feature or request sig:php
Projects
Status: Done
Development

No branches or pull requests

2 participants