-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: version control system (VCS) information: revision #1144
Comments
related to #915 |
We should also discuss whether or not |
Relates to #1383 .
@jschaf - feel free to comment here on whether or not that helps/works. Happy to get feedback / discuss this further. I think the core attributes are there in the registry, but we haven't identified event/trace specifics, yet. |
Yep, works for me. Thank you for following up. For feedback, the keys seem a touch wordy with |
Proposal: add
vcs.revision
as a semantic convention key.It's often useful to add the version control revision, like a Git commit hash, to logs and traces that indicate the commit that the binary was built from. The vcs.revision is helpful to debug production issues.
As a counterpoint,
service.version
might already include the information or be detailed enough to identify the commit.Complicating matters: should there also be
vcs.repo
to denote which repo the commit originated from?The text was updated successfully, but these errors were encountered: