Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown generation: render string examples with quotes #1157

Open
lmolkova opened this issue Jun 14, 2024 · 1 comment
Open

Markdown generation: render string examples with quotes #1157

lmolkova opened this issue Jun 14, 2024 · 1 comment
Labels
tooling Regarding build, workflows, build-tools, ...

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Jun 14, 2024 •
edited
Loading

We should render examples in MD tables with quotes around strings.

In some cases it makes spec more readable: e.g. http.response.status_code: 503 and error.type: "503"
@lmolkova lmolkova moved this to Template Generation Fixes in Semantic Conventions Tooling Jun 14, 2024
@lmolkova lmolkova added the tooling Regarding build, workflows, build-tools, ... label Jun 24, 2024
@arminru arminru mentioned this issue Jun 25, 2024
Merged
@lmolkova
Copy link
Contributor Author

lmolkova commented Jul 10, 2024 •
edited
Loading

Another example where is could be useful: #1233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tooling Regarding build, workflows, build-tools, ...
Projects
Semantic Conventions Tooling
Status: Template Generation Fixes
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmolkova @reyang