Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we discourage array-based attributes on metrics? #1546

Open
trask opened this issue Nov 4, 2024 · 1 comment
Open

Should we discourage array-based attributes on metrics? #1546

trask opened this issue Nov 4, 2024 · 1 comment

Comments

@trask
Copy link
Member

trask commented Nov 4, 2024

We've hesitated to add array-based attributes (e.g. db.collection.names) in the past due to concern that they aren't well supported today in metrics backends.

Another recent example is db.cosmosdb.regions_contacted.

Capturing these as attributes on metrics gives users the chance to aggregate across metrics where db.collection.names contains X, or db.cosmosdb.regions_contacted contains Y, which seems to be useful.

Another benefit of including these attributes on metrics is that they can be meaningful characteristics to split time series on.

@trask
Copy link
Member Author

trask commented Nov 10, 2024

I think my specific concern around db.collection.names is resolved by #1566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant