Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQS Event and SQS Message have links to SQS message AWSTraceHeader? #238

Open
rackerWard opened this issue Aug 7, 2023 · 1 comment
Open
Assignees

Comments

@rackerWard
Copy link

In the aws-lambda.md https://github.com/open-telemetry/semantic-conventions/blob/main/docs/faas/aws-lambda.md SQS it seems the SQS Event will have a span link for each message containing AWSTraceHeader and each SQS Message will have a span link to the AWSTraceHeader

Is there a reason the span link is performed on both the SQS Event and the SQS Message? What is the intent behind adding the span links to the SQS Event?

Is the intent so that the SQS Event's span links document all the SQS messages received? Because the lambda may not process all of the SQS Messages or may not call the instrumentation for processing SQS messages?

Doesn't this create a tree where the SQS Message trace context has two entry points into the SQS trigger Lambda invocation? One at the SQS Event (Lambda Invoke) and the SQS Message span?

What kind of trace trees are not allowed in OpenTelemetry? What kind of trace trees should be expected?

@github-actions github-actions bot added the Stale label Feb 15, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 25, 2024
@joaopgrassi
Copy link
Member

This was closed by mistake by the stale bot. Re-opening

@joaopgrassi joaopgrassi removed the Stale label Feb 26, 2024
@joaopgrassi joaopgrassi reopened this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants