db.mssql.instance_name vs db.instance.id and server.port

[lmolkova]

Attribute	Type	Description	Examples
db.mssql.instance_name	string	The Microsoft SQL Server instance name connecting to. This name is used to determine the port of a named instance. [1]	MSSQLSERVER

[1]: If setting a db.mssql.instance_name, server.port is no longer required (but still recommended if non-standard).

Issues:

1. It sounds like generic db.instance.id can be used. Related Should db.instance.id replace elastic and mssql specific attributes? #725
2. Based on SQL Server docs, ports are dynamic, so server.port is not known at all and connection is made against [hostname + instance name](Based on named instances docs). So probably network.address.port should be use here instead. Related: DB/messaging/rpc(?): should logical operations include network.* attributes #690

[Oberon00]

See #725 (comment):

AFAIK, the MS SQL instance does not match your proposed description of db.instance.id. It seems to be a quite special concept, I wonder if you will find anything equivalent in any other db.
MS SQL instances are not members of a cluster. Depending on which "instance" you connect to, you will have different databases. This instance concept seems to allow running logically distinct DBs on the same hostname, so it's rather the opposite of clustering.

https://learn.microsoft.com/en-us/sql/database-engine/configure-windows/database-engine-instances-sql-server?view=sql-server-ver16

[trask]

@lmolkova is this resolved by #911?

[lmolkova]

@lmolkova is this resolved by #911?

yes, closing this one.

The tl;dr: db.mssql.instance_name is now part of db.namespace following {instance_name.database name} pattern. Default instance name is not populated.