Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make requirement_level required #892

Open
trisch-me opened this issue Apr 5, 2024 · 2 comments
Open

Make requirement_level required #892

trisch-me opened this issue Apr 5, 2024 · 2 comments
Assignees

Comments

@trisch-me
Copy link
Contributor

Explicit is better than implicit.

Recently while moving attributes to the registry we have started to add also requirement_level everywhere to make it explicit.

I propose to make it even required as we recently did with stability and enforce through build-tools.

@trisch-me trisch-me self-assigned this Apr 5, 2024
@joaopgrassi
Copy link
Member

I support this! I also prefer it to be explicitly set than relying on defaults/omitted.

@lmolkova
Copy link
Contributor

lmolkova commented Apr 8, 2024

Should we expand the decision to everything else going forward? I.e. no default values (except null for note and other fully optional things)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants