Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should we do with the sigstore files? #53

Open
ocelotl opened this issue Jul 8, 2024 · 3 comments
Open

What should we do with the sigstore files? #53

ocelotl opened this issue Jul 8, 2024 · 3 comments
Assignees
Labels
code signing Items related to questions, best practices and recommendations around code signing

Comments

@ocelotl
Copy link

ocelotl commented Jul 8, 2024

I managed to use a github action to include the sigstore file in a release:

https://github.com/SecuringCarter/opentelemetry-python/releases/tag/6

Is this what we want to do with the sigstore files?

@ocelotl
Copy link
Author

ocelotl commented Jul 8, 2024

@jpkrohling

@jpkrohling jpkrohling self-assigned this Jul 9, 2024
@jpkrohling
Copy link
Member

Not quite: checking the Python docs, I would expect the sigstore file to be uncompressed under the released artifacts. Do you provide any archive with the artifacts being released? Or are those only the ones provided automatically by GitHub?

@jpkrohling jpkrohling added the code signing Items related to questions, best practices and recommendations around code signing label Jul 11, 2024
@jpkrohling
Copy link
Member

I see now that you are signing only one file, opentelemetry-api/pyproject.toml. Would that be sufficient to reassure your users? Python itself is signed with sigstore as well, but they distribute a tgz file and sign that tgz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code signing Items related to questions, best practices and recommendations around code signing
Projects
None yet
Development

No branches or pull requests

2 participants