✨ [#108] Admin action to check Abonnement callback status #186
Conversation
|
@annashamray hmm that's right, though if it's on the detail view, it isn't really convenient if you want to check multiple subscriptions, because you'd have to open every detail page. Maybe there should be a button/action to trigger it? Also come to think of it, I'm not sure if the |
stevenbal
force-pushed
the
feature/108-abonnement-admin-callback-url-reachable
branch
3 times, most recently
from
2238c16
to
223bfde
Compare
stevenbal
changed the title
|
@annashamray I've changed it to a custom admin action with a shortcut button to trigger it for all Subscriptions. I've also added a filter on the result to make it easier to check which status checks failed
|
| self._request = request | ||
| return super().changelist_view(request, extra_context=extra_context) | ||
|
|
||
| def check_all_callback_urls(self, request): |
There was a problem hiding this comment.
Tbh I think having both action and button is a little excessive. When you select objects for the action you can select everything (even if the number of objects is more than 100), which defeats the purpose of the button in my eyes
But it's up to you, so treat this comment as optional
There was a problem hiding this comment.
I added the button to make it a bit more visible and easy for admins, since Alex mentioned that the existence of these kinds of actions is not always clear right away: #108 (comment).
There was a problem hiding this comment.
Thanks for the explanation!
|
|
||
| Any subsequent executions of this action will remove the previous results from the session | ||
| """ | ||
| validator = CallbackURLValidator("callback_url", "auth") |
There was a problem hiding this comment.
Nice reusage of the existing validator
with a custom button to run this action for all Abonnementen
stevenbal
force-pushed
the
feature/108-abonnement-admin-callback-url-reachable
branch
from
223bfde
to
484897f
Compare
stevenbal
deleted the
feature/108-abonnement-admin-callback-url-reachable
branch
fixes #108
Changes: