Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoe hou je je abonnement in stand bij een nieuwe versie van een zaaktype? #144

Open
alextreme opened this issue Apr 22, 2024 · 5 comments
Open

Comments

@alextreme
Copy link
Contributor

DH Taiga 420

Hoe hou je je abonnement in stand bij een nieuwe versie van een zaaktype? Meer een open vraag, hier heb ik eigenlijk geen antwoord op (behalve opnieuw aanmaken).

@joeribekker
Copy link
Member

joeribekker commented Jun 18, 2024

Refinement: This sounds like a problem indeed.

We either need to 1) rework the whole "use uuid" idea (not likely to happen, seeing its even part of the NL API strategy) or 2) the Catalog API should not change the uuid when the version changes (much desired from me personally)

Zaaktypes:

  • api/v1/zaaktypen/abc123 (version 1 of zaaktype foo)
  • api/v1/zaaktypen/efd567 (version 2 of zaaktype foo)

Objecttypes:

  • api/v1/objecttype/aaa111 (latest version of objecttype bar)
  • api/v1/objecttype/aaa111/version/1 (version 1 of objecttype bar)
  • api/v1/objecttype/aaa111/version/2 (version 2 of objecttype bar)

So, we should maybe adopt the Objecttypes versioning scheme so you can subscribe to the "latest" version URL.

@joeribekker joeribekker self-assigned this Jun 18, 2024
@alextreme
Copy link
Contributor Author

alextreme commented Jun 18, 2024

Related Gemma zaken issues:

VNG-Realisatie/gemma-zaken#1851
VNG-Realisatie/gemma-zaken#1857

Afaik this was (and not anymore) considered tackled in Catalogi API v1.3 (Historie model)

https://vng-realisatie.github.io/gemma-zaken/standaard/catalogi/release_notes.html

@joeribekker
Copy link
Member

If you can find there if UUIDs are no longer unique, show me a screenshot :)

@alextreme
Copy link
Contributor Author

@joeribekker see the details from the Historiemodel Catalogi API, where non-unique UUIDs were implied:

https://michielverhoef.github.io/gemma-zaken/standaard/catalogi/#ztc-013

But this was reverted as far as I know. It may cause our developer-heads to explode and have too many consequences throughout the codebase but from a API backwards-compatibility sense it made sense in my eyes

@joeribekker
Copy link
Member

Refinement: We could:

  1. Change Notification API to save subscriptions based on zaaktype identificatie instead of uuid AND change the catalog API to sent this identificatie as well AND modify the Zaken API to sent/use the identificatie of the zaaktype (lots of odd changes in the API spec)
  2. Monitor new zaaktypes, check the identificatie of this zaaktype, check all zaaktypes that have the same identificatie, get their uuids, then update the notification subscriptions (does not require changes in the standard, but feels very clunky)
  3. Allow subscriptions on a catalog, so you will get all notifications for all zaaktypes in that catalog thus also the new versions. This requires

The only way to change this without changing the standard is with option 2 but we highly recommend changing the API standard with this scenario in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants