Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation bug #1993

Closed
shahnoor-khan opened this issue Mar 15, 2023 · 8 comments
Closed

Translation bug #1993

shahnoor-khan opened this issue Mar 15, 2023 · 8 comments

Comments

@shahnoor-khan
Copy link

shahnoor-khan commented Mar 15, 2023

when I was changing the language, the theme and change password title isn't getting translated from English to other languages. I attached the screenshot below which shows that.

translation

@shahnoor-khan
Copy link
Author

@jawidMuhammadi I'm new to mifos community. Can I work on this issue and translation related issues across the application?

@PratyushSingh07
Copy link
Collaborator

Hi @shahnoor-khan I have already opened an issue #1913 which deals with the same

@shahnoor-khan
Copy link
Author

Hi @PratyushSingh07 I think the translation bug is present across the application and I faced this on different page. I just opened the issue because it's on different screen and highlighting them here make it easy to keep track.

@PratyushSingh07
Copy link
Collaborator

Hi @PratyushSingh07 I think the translation bug is present across the application and I faced this on different page. I just opened the issue because it's on different screen and highlighting them here make it easy to keep track.

yes this is indeed present across the app and at the time I had opened the issue no one was really active over here ,hence the issue would feel incomplete to new contributors. However I have been working on this issue simultaneously for a while now , I will be opening a PR by EOW.

@shahnoor-khan
Copy link
Author

I didn't knew it because it was not assigned to anyone and I thought no one was on it. Are you working on this screen as well ?

@PratyushSingh07
Copy link
Collaborator

I didn't knew it because it was not assigned to anyone and I thought no one was on it. Are you working on this screen as well ?

yes,the root cause of the issue is same and I believe changing that will fix its behaviour throughout the app. However if I am unable to complete this task by the end of week then I shall gladly pass this on to you

@PratyushSingh07
Copy link
Collaborator

Meanwhile I think we should close this issue @shahnoor-khan as this seems redundant and you can just tag me on #1913 in case you need an update

@shahnoor-khan
Copy link
Author

Okay 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants