Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: edit button in user profile screen #2460

Open
PratyushSingh07 opened this issue Dec 28, 2023 · 11 comments
Open

Feat: edit button in user profile screen #2460

PratyushSingh07 opened this issue Dec 28, 2023 · 11 comments

Comments

@PratyushSingh07
Copy link
Collaborator

Summary:

There is an edit button in user profile screen which was also present in the intital xml design. However there hasn't been any implementation of that button.

Steps to reproduce:

  • click on user profile image
  • click on the top right corner of the screen

Expected behaviour:

  • some sort of functionality that would mimic the edit feature

Observed behaviour:

  • nothing happens

Device and Android version:

Device: Pixel 7
Android: 14

Screenshots:
modified dark

@PratyushSingh07
Copy link
Collaborator Author

@therajanmaurya any suggestions ?

@ashutosh-kumar-kushwaha

I want to work on this. Please assign this to me. @PratyushSingh07

@PratyushSingh07
Copy link
Collaborator Author

Hey @ashutosh-kumar-kushwaha this issue has been labelled as community discussion which means that we are yet to decide the functionality of this feature.
This cannot be assigned until we have a clear idea of what needs to be implemented

@Ronitrs5
Copy link

Ronitrs5 commented Jan 5, 2024

Hey @PratyushSingh07. So, when clicked on the top right pencil (edit) icon, the data that was changed should be changed, but nothing changes. So we just need to check the java/kotlin code regarding to that button and what logic is written on the setOnClickListener() method. So you can assign this to me.

@PratyushSingh07
Copy link
Collaborator Author

We haven't implemented the logic for this @Ronitrs5 . Also this screen is now in compose so you won't exactly find a setOnClickListener() .

@Ronitrs5
Copy link

Ronitrs5 commented Jan 6, 2024

Ohh I see, my apologies @PratyushSingh07 for not knowing that it was built on compose. However, I can work on the functionality when button is pressed if the logic was known to me. (I assume we want to save the updates)

@shalenMathew
Copy link

We haven't implemented the logic for this @Ronitrs5 . Also this screen is now in compose so you won't exactly find a setOnClickListener() .

so are u asking to create a dummy class to test if the button functionality will work as expected?

@r1shhh1
Copy link

r1shhh1 commented Feb 22, 2024

@PratyushSingh07 i would like to work on this issue

@PratyushSingh07
Copy link
Collaborator Author

hey @r1shhh1 , we still arent sure regarding the functionality of this feature hence I have put this under community discussion. You can open issues regarding xml to compose migration as this is what we are focusing on

@r1shhh1
Copy link

r1shhh1 commented Feb 22, 2024

Sure @PratyushSingh07

@yashc18
Copy link

yashc18 commented Oct 12, 2024

is functionality of this feature decided?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants