-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: edit button in user profile screen #2460
Comments
@therajanmaurya any suggestions ? |
I want to work on this. Please assign this to me. @PratyushSingh07 |
Hey @ashutosh-kumar-kushwaha this issue has been labelled as community discussion which means that we are yet to decide the functionality of this feature. |
Hey @PratyushSingh07. So, when clicked on the top right pencil (edit) icon, the data that was changed should be changed, but nothing changes. So we just need to check the java/kotlin code regarding to that button and what logic is written on the setOnClickListener() method. So you can assign this to me. |
We haven't implemented the logic for this @Ronitrs5 . Also this screen is now in compose so you won't exactly find a setOnClickListener() . |
Ohh I see, my apologies @PratyushSingh07 for not knowing that it was built on compose. However, I can work on the functionality when button is pressed if the logic was known to me. (I assume we want to save the updates) |
so are u asking to create a dummy class to test if the button functionality will work as expected? |
@PratyushSingh07 i would like to work on this issue |
hey @r1shhh1 , we still arent sure regarding the functionality of this feature hence I have put this under community discussion. You can open issues regarding xml to compose migration as this is what we are focusing on |
Sure @PratyushSingh07 |
is functionality of this feature decided? |
Summary:
There is an edit button in user profile screen which was also present in the intital xml design. However there hasn't been any implementation of that button.
Steps to reproduce:
Expected behaviour:
Observed behaviour:
Device and Android version:
Device: Pixel 7
Android: 14
Screenshots:
The text was updated successfully, but these errors were encountered: