Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all "Hardcoded Strings" in all XML file of this app. #1090

Open
deepak-prajapatii opened this issue Jan 2, 2021 · 7 comments
Open

Comments

@deepak-prajapatii
Copy link

Summary:

Remove all "Hardcoded string" by creating the strings in "strings.xml" file.

Steps to reproduce:

Hardcoded strings are present in "item_si.xml" and many more XML files. Simply open the file and wait for the loading of XML. You will find that there are many hardcoded strings.

Expected behavior:

The app should not show the "Hardcoded string" warning.

Observed behavior:

Warning Screenshot in "item_si" XML file:
Capture

@deepak-prajapatii
Copy link
Author

@naman14 @shiv07tiwari @devansh-299 please review my issue.

@EGOR-IND
Copy link
Contributor

EGOR-IND commented Jan 2, 2021

@deepak-prajapatii are you working on this issue, if not can i work on this

@deepak-prajapatii
Copy link
Author

@deepak-prajapatii are you working on this issue, if not can i work on this

@EGOR-IND No, I am already working on this issue.

@deepak-prajapatii
Copy link
Author

@deepak-prajapatii are you working on this issue, if not can i work on this

@EGOR-IND I am already working on this issue.

@EGOR-IND
Copy link
Contributor

EGOR-IND commented Jan 2, 2021

@deepak-prajapatii are you working on this issue, if not can i work on this

@EGOR-IND No, I am already working on this issue.

No problem, make a good contribution:).

@deepak-prajapatii
Copy link
Author

@deepak-prajapatii are you working on this issue, if not can i work on this

@EGOR-IND No, I am already working on this issue.

No problem, make a good contribution:).

Sure.

@SGI-CAPP-AT2
Copy link

Hey there is this issue still valid?
If yes i would like to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants