Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adding extra text to be share with QR code in android sharesheet in showQrActivity #1131

Open
Harshad09 opened this issue Jan 6, 2021 · 5 comments

Comments

@Harshad09
Copy link

Summary:

Adding extra text to be shared with QR code with Intent in android Sharesheet in showQrActivity, for better user experience.

Steps to reproduce:

  1. Go to Request fragment in Payments
  2. Click on show code
  3. Click on the share icon (located at top right)
  4. Choose any app to share

Expected behavior:

The extra text should be share with a QR code to ease the user experience

Device and Android version:

Redmi Note 5 Pro
Android 9 Pie
custom ROM

@devansh-299
Copy link
Collaborator

Not sure if we have the deep link handled for Scan QR functionality but in case we have the feature, it would be better to pass the deep link in the text as well.

@Harshad09
Copy link
Author

Not sure if we have the deep link handled for Scan QR functionality but in case we have the feature, it would be better to pass the deep link in the text as well.

Yes, Deep linking functionality should be there, as for now is this feature acceptable or I have some suggested changes @devansh-299

@Harshad09
Copy link
Author

PhonePe also uses this type of extra text when we share qr code.

@TanishMoral11
Copy link

Hi @Harshad09 , I’d like to work on this issue. Could you assign it to me?

@TanishMoral11
Copy link

hey @Harshad09 , if this issue is still open, can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants