Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to open the receipt link in browser. #1220

Open
EGOR-IND opened this issue Feb 10, 2021 · 6 comments
Open

Add feature to open the receipt link in browser. #1220

EGOR-IND opened this issue Feb 10, 2021 · 6 comments

Comments

@EGOR-IND
Copy link
Contributor

Summary:

The receipt link given in receipt activity is not doing anything by itself, it even has the color of a link which makes it look like a working link to a user, but it's not clickable.

Steps to reproduce:

  1. Go to receipt activity
  2. click on receipt link

Expected behavior:

It should open that link in a browser.

Observed behavior:

Right now it's not clickable.

Device and Android version:

VIVOY83, Android Version = 8.1.0

Screenshots:

@EGOR-IND
Copy link
Contributor Author

I'm working on this issue.

@EGOR-IND
Copy link
Contributor Author

@haran2248 @devansh-299 can you give your views on this issue.

@EGOR-IND EGOR-IND changed the title Add feature to apen the receipt link in browser. Add feature to open the receipt link in browser. Feb 10, 2021
@haran2248
Copy link
Contributor

Actually the given link is just a deeplink even if you make it open in the browser it is of no use i guess.Only if the person has the app the deeplink will open.But in this case the share and copy feature has been implemented so i think it is of no use.
@divyank00 @devansh-299 Please confirm

@EGOR-IND
Copy link
Contributor Author

Yes it is a deeplink though, but the link is actually there and even if we share or copy it what use will it be, I was actually thinking that if we're copying and sharing the link then there should be a way of accessing that link through app.

@haran2248
Copy link
Contributor

Yeah but if you put it in a browser.It will show invalid address.If the user has the app it will open in the app.Opening it through chrome Im not sure if it is a good idea,But you can try making a PR anyway,It might be useful :)

@EGOR-IND
Copy link
Contributor Author

No I'm saying we should open it in the app, there is a way I think to open a deeplink in the app. Let me do some research on it and then we'll talk😊.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants