Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding some more mathematical shapes #187

Draft
wants to merge 5 commits into
base: v3
Choose a base branch
from
Draft

adding some more mathematical shapes #187

wants to merge 5 commits into from

Conversation

lzehl
Copy link
Member

@lzehl lzehl commented Aug 9, 2022

related to #186

@lzehl
Copy link
Member Author

lzehl commented Aug 9, 2022

@xgui3783 and @apdavison before I continue here I would need your feedback.
Goal of these schemas are to define mathematical shapes without defining an actual coordinate space.

Which one do we most likely need ? How do we define them best / consistently ?

@xgui3783
Copy link
Collaborator

xgui3783 commented Aug 9, 2022

My immediate focus is that (IMO) all are 2D shapes, except sphere, which IMO is a 3D concept. Its 2D concept would be a circle.

I can Imagine circle used.

Would line segment also be included (or is it already included in a previous commit?)

Seems strange to not have rectangle, though one would argue that a rectangle is a special parallelogram. But the same can be said for square.

@lzehl
Copy link
Member Author

lzehl commented Aug 9, 2022

@xgui3783 #186 has various 3D shapes besides sphere. But before I implement them I wanted to have feedback.

I would define a line as a coordinate point only within a given space. Therefore it is excluded here from mathematical shapes that are defined without a space. There will be another PR in connection with the annotation revision with a Contour schema (which can be a line).

Note that circle, rectangle and ellipse were already added to mathematical shapes in a previous PR.

@UlrikeS91 UlrikeS91 added the request any request or update for schemas label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request any request or update for schemas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding further shapes (as first assessment, with further extension based on use cases)
3 participants