Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "keyword" category to all atlas elements #258

Open
lzehl opened this issue Apr 19, 2023 · 5 comments
Open

add "keyword" category to all atlas elements #258

lzehl opened this issue Apr 19, 2023 · 5 comments
Assignees
Labels
help extra attention is needed question further information is requested request any request or update for schemas

Comments

@lzehl
Copy link
Member

lzehl commented Apr 19, 2023

@aeidi89 could you take this over or do you need help with this?

@UlrikeS91
Copy link
Collaborator

Looking (slowly but steadily) trough issues and PR. I can fix this one, but it would be great to agree on which elements are meant.

schema keyword? argument
annotation no concept schema & atlas annotation should not get the category
atlas annotation no only ever embedded
brain atlas yes
brain atlas version yes
common coordinate space yes?
common coordinate space version yes?
parcellation entity yes
parcellation entity version yes
parcellation terminology no only ever embedded
parcellation terminology version no only ever embedded

Does that make sense? And what about the non-atlas elements?

schema keyword? argument
customAnatomicalEntity yes?
custom annotation no?
custom coordinate space no?

@UlrikeS91 UlrikeS91 self-assigned this Apr 22, 2024
@lzehl
Copy link
Member Author

lzehl commented Apr 26, 2024

I need more context. I do not understand what is meant here

@lzehl
Copy link
Member Author

lzehl commented Apr 26, 2024

do you mean you want to have e.g. the term "brain atlas" as a structured keyword for other datasets or do you want to have e.g. "WHSSD Atlas" as potential keyword?

The latter I would not like to support. The purpose / usage of atlas elements should be defined through "inputData" for BAs, BAVs, CCSs, CCSVs,in DSVs or through study targets for PEs, CAEs, or PEVs. For the first we can discuss how to register this best.

@UlrikeS91
Copy link
Collaborator

I just interpreted the issue, no request from my side for anything specific. The way I understood this issue was that all atlas schemas should receive this:

{
  "_categories": [
    "keyword"
  ]
}

I this is not what was meant, I need some more information. But if that is what was meant, I was trying to figure out which atlas schemas should in fact receive the category.

Does that make more sense?

@lzehl
Copy link
Member Author

lzehl commented Apr 29, 2024

If that was the suggestion then I would disagree with adding this category to any atlas schemas or at least would like to further discuss this.

@UlrikeS91 UlrikeS91 added help extra attention is needed question further information is requested request any request or update for schemas labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help extra attention is needed question further information is requested request any request or update for schemas
Projects
None yet
Development

No branches or pull requests

2 participants