Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON schema #38

Open
aeidi89 opened this issue Sep 15, 2020 · 4 comments
Open

Update JSON schema #38

aeidi89 opened this issue Sep 15, 2020 · 4 comments
Assignees
Labels
major update large workload or major update needed to complete request any request or update for schemas technical anything related to the repository

Comments

@aeidi89
Copy link
Collaborator

aeidi89 commented Sep 15, 2020

Update the current 0.7 JSON schema to 0.9 JSON schema.

@aeidi89 aeidi89 modified the milestone: SANDS core Sep 15, 2020
@UlrikeS91
Copy link
Collaborator

To do so, the validator has to be updated along with the actual change. @lzehl and I talked about this and thought it would be nice to update the validator to a more general one that can check against different drafts dependent on the draft used within schemas with "$schema": "http://json-schema.org/draft-XY/schema#". --> If XY is 07, check against Draft7Validator. If XY is 09, check against Draft9Validator.

@skoehnen, could you create such a validator?

@UlrikeS91
Copy link
Collaborator

@skoehnen and @lzehl, I don''t know the status of this. @xgui3783 has performed some fixes related to this issue, but is it fixed?

@lzehl
Copy link
Member

lzehl commented Nov 16, 2020

@skoehnen OR @olinux : is the generator in the main openMINDS repo now using draft-07 or draft-09? or can you even choose between the json-schema draft (not sure if our schemas would actually look different...)?

@skoehnen
Copy link
Collaborator

I am still validating for the draft 7 and haven't encountered any errors yet ;)
But with the template language we could switch the draft version without it affecting the schemas.
What do you think @olinux?

@UlrikeS91 UlrikeS91 added request any request or update for schemas technical anything related to the repository major update large workload or major update needed to complete labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major update large workload or major update needed to complete request any request or update for schemas technical anything related to the repository
Projects
None yet
Development

No branches or pull requests

4 participants