Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute reading #2

Open
xxirii opened this issue Nov 10, 2017 · 0 comments
Open

Attribute reading #2

xxirii opened this issue Nov 10, 2017 · 0 comments

Comments

@xxirii
Copy link
Contributor

xxirii commented Nov 10, 2017

Actual behavior

The plugin does not read all group and dataset attributes correctly. More attribute readers need to be implemented although the necessary ones for visualization are present. Some attribute readers are not working properly or may be improved:

  • the label axis reader for meshes (see PMDField::SetAxisLabel) work in the assumption that all string have the same size. This is not necessary the case or codes need to be aware of this while creation pmd files.
  • Similar issue for FieldBoundary and FieldBoundaryParameter

Expected behavior

  • The reader should be able to read array of string with string of different sizes

Step to reproduce this behavior

  • See output of corresponding methods (e.g. PMDField::SetAxisLabel)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant