Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Allow using different container engines #20

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

aaannz
Copy link
Member

@aaannz aaannz commented Feb 2, 2023

This PR does some refactoring of code to allow adding different container engines. Also in PR I add volume management outside of podman and skopeo support.

TODO:

  • standalone crun support
  • tests

Partly fixes #4

- Add new Available trait
- Job now uses engine provided by get_engine function
- Use crun for podman if available
- Package crun for opensuse variants
- it's not implemented anyway
- use skopeo to copy image from registry to local directory
- on image cleanup remove directory
- CRun::is_available now checks for it's dependencies which we do
  not need if used through podman
Instead of relying outside dep check, move this check to
CRun::is_available.

Also add some debug logging.
- when using skopeo we need transport prefix, if there is non, use
  docker:// as default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use skopeo and runc instead of podman
1 participant