Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch file cannot be loaded #24

Open
hramrach opened this issue Jun 6, 2022 · 1 comment
Open

patch file cannot be loaded #24

hramrach opened this issue Jun 6, 2022 · 1 comment

Comments

@hramrach
Copy link
Contributor

hramrach commented Jun 6, 2022

0072-drm-i915-add-module-parameter-compiler-hints.txt

Failed to load patch "patches.drm/0072-drm-i915-add-module-parameter-compiler-hints"
Unexpected end of file

@ptesarik
Copy link
Contributor

ptesarik commented Jan 3, 2025

The patch file does not end with a newline. GNU patch will also complain about it, but it succeeds anyway:

petr@mordecai:~/rapidquilt/issue31> patch -p1 < patches/unexpected-eof.patch
patching file drivers/gpu/drm/i915/i915_drv.c
patching file drivers/gpu/drm/i915/i915_drv.h
patch unexpectedly ends in middle of line
petr@mordecai:~/rapidquilt/issue31> echo $?
0

IIRC this case was discussed back in 2019, and the decision was against relaxed parsing. The rationale was that scripts/sequence-patch.sh --fast (from SUSE kernel-source tree) concatenates multiple patches into one big patch, and then a missing end of line may break parsing of the following patch.

@hramrach I am open to review this decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants