Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL to Debian Release.key is wrong #1273

Open
faho opened this issue Nov 28, 2022 · 1 comment · May be fixed by #1344
Open

URL to Debian Release.key is wrong #1273

faho opened this issue Nov 28, 2022 · 1 comment · May be fixed by #1344
Labels

Comments

@faho
Copy link

faho commented Nov 28, 2022

Describe the bug
The instructions to add a Debian repository have the wrong url to the release key.

Instead of e.g. https://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_10/Release.key they look like https://download.opensuse.org/repositories/shells:fish:release:3/Debian_10/Release.key - the "/" between "shells:" and "fish:" and "release:" are missing, causing it to 404.

The instructions look like

echo 'deb http://download.opensuse.org/repositories/shells:/fish:/release:/3/Debian_9.0/ /' | sudo tee /etc/apt/sources.list.d/shells:fish:release:3.list
curl -fsSL https://download.opensuse.org/repositories/shells:fish:release:3/Debian_9.0/Release.key | gpg --dearmor | sudo tee /etc/apt/trusted.gpg.d/shells_fish_release_3.gpg > /dev/null

The repository line is correct, the Release.key line isn't.

It seems this is caused by

"echo 'deb #{v[:repo].gsub(/(\w):(\w)/, '\1:/\2').gsub(/^https/, 'http')} /' | sudo tee /etc/apt/sources.list.d/#{@project}.list\ncurl -fsSL #{v[:repo]}Release.key | gpg --dearmor | sudo tee /etc/apt/trusted.gpg.d/#{@project.gsub(':', '_')}.gpg > /dev/null\nsudo apt update\nsudo apt install #{@package}"
doing some replacement on the repo for the echo deb part, but not the later curl part.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://software.opensuse.org/download.html?project=shells%3Afish%3Arelease%3A3&package=fish'
  2. Click on 'Debian', then 'Add repository'
  3. See error

Expected behavior
The link is correct.

Environment (please complete the following information):

  • OS: N/A
  • Browser Firefox
  • Version 107

Additional context
N/A

@faho faho added the Bug 💀 label Nov 28, 2022
z3ntu added a commit to z3ntu/software-o-o that referenced this issue May 23, 2023
Currently some instructions like openSUSE or Debian link to e.g.
/repositories/hardware:razer/ instead of /repositories/hardware:/razer/
with an extra slash but the version without the extra slash return HTTP
404 and therefore don't work.

Make sure to add the path fixup everywhere where the v[:repo] variable
is used.

Fixes openSUSE#1142
Fixes openSUSE#1273
@z3ntu z3ntu linked a pull request May 23, 2023 that will close this issue
1 task
@FWDekker
Copy link

I think this issue has since been fixed. Though the PR has not been merged and though the URLs has not changed, it looks like the link no longer 404s. Probably a back-end change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants