Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The parameter sigma_data for KarrasDenoiser. #41

Open
moonbow721 opened this issue Jul 21, 2023 · 0 comments
Open

The parameter sigma_data for KarrasDenoiser. #41

moonbow721 opened this issue Jul 21, 2023 · 0 comments

Comments

@moonbow721
Copy link

Hi,
thank you for your great work on this project!
I have been comparing the noise schedule implementation between this project and EDM, and I noticed some odd differences.
In particular, I was looking at this code snippet:

diffusion = KarrasDenoiser(
sigma_data=0.5,
sigma_max=sigma_max,
sigma_min=sigma_min,
distillation=distillation,
weight_schedule=weight_schedule,
)
return model, diffusion

The image tensors in both projects are normalized in the range [-1, 1]. Based on my understanding, the parameter "sigma_data" should be set to 1.0, similar to the EDM settings. Could you kindly clarify the reason behind the difference in the "sigma_data" value between the two projects?

@moonbow721 moonbow721 changed the title The parameter sigma_data for datasets. The parameter sigma_data for KarrasDenoiser. Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant